Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gnoland): Update error type for invalid deposit #2614

Merged
merged 5 commits into from
Jul 29, 2024
Merged

fix(gnoland): Update error type for invalid deposit #2614

merged 5 commits into from
Jul 29, 2024

Conversation

linhpn99
Copy link
Contributor

Should use a more appropriate error type

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Jul 22, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.11%. Comparing base (bf61069) to head (8326a7e).

Files Patch % Lines
gno.land/pkg/sdk/vm/msgs.go 0.00% 1 Missing ⚠️
tm2/pkg/sdk/bank/msgs.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2614      +/-   ##
==========================================
- Coverage   60.12%   60.11%   -0.01%     
==========================================
  Files         560      560              
  Lines       74686    74686              
==========================================
- Hits        44902    44895       -7     
- Misses      26392    26400       +8     
+ Partials     3392     3391       -1
Flag Coverage Δ
contribs/gnodev 61.40% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (ø)
gno.land 64.15% <0.00%> (ø)
gnovm 64.18% <ø> (ø)
misc/genstd 80.54% <ø> (ø)
misc/logos 19.88% <ø> (-0.36%) ⬇️
tm2 61.98% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the 📦 🌐 tendermint v2 Issues or PRs tm2 related label Jul 26, 2024
@linhpn99 linhpn99 requested a review from thehowl July 26, 2024 01:30
@thehowl thehowl merged commit e844fc1 into gnolang:master Jul 29, 2024
112 of 115 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehowl thehowl thehowl approved these changes

@moul moul Awaiting requested review from moul

@gfanton gfanton Awaiting requested review from gfanton

@jaekwon jaekwon Awaiting requested review from jaekwon

@piux2 piux2 Awaiting requested review from piux2

@zivkovicmilos zivkovicmilos Awaiting requested review from zivkovicmilos

Assignees

@linhpn99 linhpn99

Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
💪 Bounties & Worx
Status: Done
🧙‍♂️gno.land core team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@linhpn99 @thehowl